Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing url in AzureBlobFileSystem #450

Open
giacomorebecchi opened this issue Dec 27, 2023 · 1 comment
Open

Support passing url in AzureBlobFileSystem #450

giacomorebecchi opened this issue Dec 27, 2023 · 1 comment

Comments

@giacomorebecchi
Copy link

I'm using adlfs to read and write files from/to Azure Blob Storage, both using a Shared Key and a Shared Access Signature.
I'm testing my code using an azurite local container, and when I test access using a SK, I can pass the whole connection string and the AIOBlobServiceClient gets correctly initialized, using as Blob endpoint the localhost.
If I want to test the SAS authentication method, passing a sas token, there is currently no way in adlfs to specify a custom account_url, as it is directly computed in the do_connect method.

I would like to propose a PR exposing the account_url kwarg in the init of the class, please let me know if it makes sense!

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Dec 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants