Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Embeds in Mermaid #49

Open
zorbash opened this issue Aug 22, 2023 · 1 comment
Open

Support Embeds in Mermaid #49

zorbash opened this issue Aug 22, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@zorbash
Copy link
Contributor

zorbash commented Aug 22, 2023

Hi @fuelen and thank you for this lovely library.

I noticed that embedded schemas are not supported when the output document is set to Mermaid. Ecto.ERD.Document.Mermaid.schemaless?/0 returns true which instructs Graph.new/2 to graph associations but not embeds. What's blocking embeds support in Mermaid? I'd be happy to contribute a PR to add support.
@fuelen
Copy link
Owner

fuelen commented Aug 23, 2023 •
edited
Loading

Hi @zorbash
Thank you for such kind words :)

What's blocking embeds support in Mermaid?

I think in previous versions of Mermaid, it was not possible to wrap entity name into quotes, thus it was not possible to specify "MyModule.MyName" as an entity name.
Seems like this limitation is absent today.
Here is a related issue mermaid-js/mermaid#3171

@fuelen fuelen added the enhancement New feature or request label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fuelen @zorbash