Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new preset: Zereth Mortis waterfall #41

Closed
wants to merge 13 commits into from

Conversation

Lunaeria
Copy link

Kind of a niche preset, but if in Zereth Mortis fishing for the jellyfish mount, the waterfall sounds are likely to drive you bananas, so maybe this could be useful to someone other than me.

Hopefully I've managed to do everything correctly, this is my first time properly using GitHub!

@funkydude
Copy link
Owner

That's a lot of sound files, are you sure they are all related to that specific waterfall?

@Lunaeria
Copy link
Author

That's a lot of sound files, are you sure they are all related to that specific waterfall?

I took them from a macro someone shared on wowhead; I do think a fair few of them aren't exclusive to the Zereth Mortis waterfall, but I had been using the macro as a temporary mute while fishing, and thought it'd be useful to have as a preset for this addon to more easily toggle it on and off.

That being said, it's such a niche thing and I suppose it'd be a shame if someone toggled it on and accidentally forgot to untoggle it. I suppose I can stick with the macro, in the end. Feel free to close/disregard this suggestion! Entirely up to you.

@funkydude
Copy link
Owner

I don't mind merging it, it was more a question of if you are willing to go through them yourself and do a "spring clean"

@funkydude
Copy link
Owner

Yes/No ?

@Lunaeria
Copy link
Author

Hello, sorry! I tried to sort through the sound files in-game but couldn't quite figure them out. Since the preset is so incredibly niche, and the mute exists as a macro anyway, I suppose it's a silly suggestion anyway. I'll close this pull request for now. Sorry!

@Lunaeria Lunaeria closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants