-
Notifications
You must be signed in to change notification settings - Fork 4
/
Copy pathtodo
122 lines (80 loc) · 2.62 KB
/
todo
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
# Todos
## Testing Driven
- example: tap seek bar doesnt work.
- optional duration? (can't work with streaming ofc)
- what is the correct 'we dont know' length?
- android: service:660 & 279 move to error state?
- add control of what lockscreen controls do?
## Done
I: Forward works even when no history
R: This is correct behaviour.
I: remove all debug_log statements (turn any critical ones into issues)
R: -
I: playlist looping by default (only on iOS)
R: -
I: you can 'next' passed the end of the queue and it wraps. Maybe this is fine?
R: Yeah, it's fine
I: test pause
R: pause is fine
I: play always resets on iOS, should unpause when paused
R: -
I: add option to specify default 'next' behaviour
R: was taking a lot of time to get correct. Have moved to own branch so we can ignore it for now
I: dont jump to -1 when run out of tracks
R: nope. at least, not for now
I: make play on -1 calls next
R: -
I: Android not clearing controls on stop
R: -
I: notification being set on seek
R: -
I: not setting artwork causes crash
R: -
I: make more fields optional
R: -
I: android: Add support for local artwork files
R: -
I: example has 'onvaluechanged needs a module' warning
R: -
I: android artwork caching
R: dirt simple but will do the job for now.
I: on iOS, when playlist is done we keep getting 'Note' in the logs
R: At end of playlist we now call Stop()
I: iOS: Add support for local artwork files
R: -
I: history broken
R: -
I: communicating OnRejected & onServiceDisconnected
R: log & set Status to Error
I: Track does not override object.GetHashCode()
R: -
I: SetPlaylist should add the uids
R: -
I: add GetPlaylist
R: playlist is now a NativeProperty
I: android: killing app doesnt remove notification
R: -
I: support lower ios versions
R: - wont worry about version yet
I: NSAppleMusicUsageDescription Permissions crash
R: easy to fix by using unoproj plist option in example
I: Simplify AndroidPlayerState situation
R: Removed it and now use PlaybackStateCompat instead
I: iOS - Always reuse the player, new player should happen only once
R: -
I: iOS - Consolidate Add/Remove Observer logic (Track the Observed things)
R: -
I: iOS: backward to beginning of history can result in only playing first track and stopping.
R: backward could return -1 and we would then set this as the current track (meaning no next track)
I: fix get playlist
R: -
I: add 'set current track'
R: -
I: add clear history
R: -
I: ios - double play on switch track
R: two issues, playimpl in set status & bad use of status from JS
I: At end of track go forward rather than next. This gives better handing of history
R: -
I: Example - click on tracks
R: -