RStudio will soon stop distributing 'ssh' client [#116]

futureverse · Nov 6, 2024 · 4a3e668 · 4a3e668
1 parent f8c38af
commit 4a3e668
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,5 +1,5 @@
 Package: parallelly
-Version: 1.38.0-9003
+Version: 1.38.0-9004
 Title: Enhancing the 'parallel' Package
 Imports:
     parallel,

diff --git a/R/utils,cluster.R b/R/utils,cluster.R
@@ -111,9 +111,14 @@ find_rshcmd <- function(which = NULL, first = FALSE, must_work = TRUE) {
     stop_if_not(length(v) == 1L)
     v
   }
-
+
+  ## Soon, RStudio will no longer come with a built-in 'ssh' client
+  ## for MS Windows. It's old and Windows (>= 10) comes with a
+  ## built-in 'ssh' client.
+  ## Source: https://github.com/HenrikBengtsson/parallelly/issues/116
   find_rstudio_ssh <- function() {
-    path <- Sys.getenv("RSTUDIO_MSYS_SSH")
+    path <- Sys.getenv("RSTUDIO_MSYS_SSH", NA_character_)
+    if (is.na(path)) return(NULL)
     if (!file_test("-d", path)) return(NULL)   
     path <- normalizePath(path)
     path_org <- Sys.getenv("PATH")