You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By inspecting the CSS Selector Spec this identifies tokens that are used at the start or end of <compound-selector>, which signals the intended use of a descendant combinator if no other token is present between them. Expand documentation on this issue and add test cases + ref to upstream tracking of the span API in the rust compiler.
Specifically, * can either start or end a selector, and # can appear at the start. The rest of the tokens like .class or ::before are to be disambiguated by adding a * star selector in front of them to force the spacing.
I think # can actually appear in places other than the start of a selector (.some-class#some-id)?
Despite that, I think this is actually an excellent workaround!
Have you ever seen that used? I think the first instinct is to write the equivalent but more logical #some-id.some-class, but you're of course right that the above can confusingly have an extra space with this PR.
I actually prefer .some-class#some-id. But I think it's fine to always insert before # until we can find a better solution as that can be a relatively rare occasion and having # alone is much more common.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41
By inspecting the CSS Selector Spec this identifies tokens that are used at the start or end of
<compound-selector>, which signals the intended use of a descendant combinator if no other token is present between them. Expand documentation on this issue and add test cases + ref to upstream tracking of the span API in the rust compiler.Specifically,
*can either start or end a selector, and#can appear at the start. The rest of the tokens like.classor::beforeare to be disambiguated by adding a*star selector in front of them to force the spacing.