Update: Update Replication of mysql_secure_installation script for current versions of mariadb-server. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add start_vmid
Add vmid settings
Add vmid support
Add vmid support
Add support for extra server and worker k3s args
Add support for master and server extra args
Add support for master and worker extra args
Example use of extra server and worker k3s extra arguements
Update Replicate mysql_secure_installation script for current versions of mariadb-server.
fvumbaca
requested changes
May 16, 2022
There was a problem hiding this comment.
Hey @mannp, thanks again for another contribution! Like before, would you be able to separate out the duplicate changes from your other MRs? This will all go a lot smother that way!
As for this specific change, could you point me to the mysql_secure_instillation script you based this change set on? I would like to take a deeper look at some of the changes suggested here.
Thanks again for the contribution!
|
@fvumbaca I used the current mysql_secure_instillation script from the latest mariadb-server code. Newer versions of mariadb-server were failing for me due to depreciated commands in the current script. I did the change a while ago, but I recall using this link; |
mannp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Replication of mysql_secure_installation script for current versions of mariadb-server.