Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underlines break Ruby code indentation for parenthesis-less method calls #1296

Closed
misaka opened this issue Jan 15, 2024 · 1 comment
Closed

Comments

@misaka
Copy link

misaka commented Jan 15, 2024

Parenthesis-less method call args were previously reported in the issue #1047 and fixed with the commit c8a3b33. However I'm finding that this breaks when the method name has underscores in it:

<%= render_to_string partial: 'some_partial',
 locals: {
     icon: nil,
     errors: [],
     title: 'Title'
 } %>

This should indent similar to how it would if render_to_string was replaced with render:

<%= render_to_string partial: 'some_partial',
                     locals: {
                         icon: nil,
                         errors: [],
                         title: 'Title'
                     } %>

<!-- The same for render: -->
<%= render partial: 'some_partial',
           locals: {
               icon: nil,
               errors: [],
               title: 'Title'
           } %>

This was tested with on a vanilla install emacs-plus (homebrew package) with an empty .emacs that only pulled in web-mode.

Output of emacs-version:

GNU Emacs 29.1.50 (build 1, aarch64-apple-darwin22.5.0, NS appkit-2299.60 Version 13.4.1 (c) (Build 22F770820d)) of 2023-08-02

And web-move-version: 17.3.17

Thanks for the great work on web-mode!

@fxbois
Copy link
Owner

fxbois commented Feb 7, 2024

it is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants