Theme adwaita - icons and enhancements #68

metal3d · 2023-07-02T23:47:18Z

This PR proposes a better generator and to bundle icons.

The colors are written with better syntax (fully named properties for colors)
Icons are taken from the Adwaita icons repository (https://gitlab.gnome.org/GNOME/adwaita-icon-theme) and converted into fyne.Resource + "Themed" if there are "symbolic" (all icons are SVG)
Fallback to fyne icons when we don't have the corresponding icon
Place the license reference in the generated sources

These icons are, at this time, not converted from Adwaita (checked when resolved):

IconNameColorAchromatic no icon found
IconNameColorChromatic no icon found
IconNameColorPalette not relevent icon
IconNameFile not sure of the icon to use
IconNameLogin no icon found

Don't hesitate to tell me which icon is badly choosen or ideas for not set icons (above).

Not defined icons are set to the default. I don't have listed everything yet.

- prefer to use fully named properties in color struct - prefer to use template to `printf` elements intead of doing it in the functions

oksvg has got some problems with gradients and with masked icon. Today, use inkscape in command line to convert them to PNG. Warning, inkscape says that it crashes with core dump even if the convertion worked. This is a bug from inkscape. The PNG files are well converted anyway.

- sizes of icon and text should respect the Adwaita sizes, so I need to set up: - padding to 8 - inline icons to 16 - text to 12 - fixed the scrollbar color to respect Adwaita colors (estimation made, there is no color set fot scrollbar in the documentation)

Actually, Adwaita doesn't document everything - at this time I need to decide which is the closer color using the theme on GNOME and comparing with a Fyne application.

andydotxyz · 2023-07-12T15:36:20Z

This looks completely amazing update thanks.
Unfortunately I don't have a suitable system to test on I don't think (my Linux is FyneDesk and X utils).
Any others of the team on Linux and have a good Gnome setup?

Jacalz · 2023-07-12T20:15:35Z

I can check it out sometime next week. Gnome on Fedora is my main desktop environment :)

While fyne-io/fyne-x#68 is not merged, using my own repository to have Adwaita theme + icons.

andydotxyz · 2023-10-04T12:29:22Z

@Jacalz just bumping this as you were going to check it out. I don't have Gnome running (at least not well ;) ).

Jacalz

Thanks for working on this. It is very cool. I just can't seem to get the icons working. All I did was to set the theme to the &Adwaita struct.

metal3d · 2023-10-05T05:03:23Z

Thanks for working on this. It is very cool. I just can't seem to get the icons working. All I did was to set the theme to the &Adwaita struct.

Weird...

go mod edit -replace "fyne.io/x/fyne=github.com/metal3d/fyne-x@theme-adwaita"
go mod tidy

All the icons are set, whatever the project, even the one on FlatHub => https://flathub.org/fr/apps/org.metal3d.scoreboard

Are you sure to have taken the right branch?

Jacalz · 2023-10-05T06:37:29Z

Hmm. Maybe not. I'll have a look later today. Sorry

Jacalz · 2023-10-05T07:50:54Z

It is definitely working on my laptop now when doing a quick test. Will have to see later today if I did something wrong on my workstation.

It might require some some size changes for v2.4.0? It seems to me like the text is very small and the blue line below the tabs is very big. In general though it looks wonderful. Nice work :)

metal3d · 2023-10-05T14:17:02Z

It might require some some size changes for v2.4.0? It seems to me like the text is very small and the blue line below the tabs is very big. In general though it looks wonderful. Nice work :)

Thanks a lot 😄

I probably leave a font scaling test by error. Sorry...

I will remove it if it's true.

Jacalz

This looks great. Thank you :)

Jacalz · 2023-10-06T06:40:38Z

I see that there are checkboxes left in the description. Are you fine with me merging or do you want to wait? :) @metal3d

andydotxyz · 2023-10-16T09:42:28Z

Let's just get this in - there will often be icons missing as we keep expending the main theme anyway.

metal3d · 2023-10-16T14:30:25Z

Thanks 😄

I'll keep an eye on newest icons, it takes the default in case of problems.

The generator takes the Adwaita git repository to generate the icons, and it's theoretically easy to add more icons in the theme.

metal3d · 2023-10-16T14:32:48Z

I see that there are checkboxes left in the description. Are you fine with me merging or do you want to wait? :) @metal3d

Sorry for this, actually I kept default for the icons I'm not sure, or if the Adwaita icon is not exactly what we mean in Fyne.

Anyway, I could, later, enhance the icon set.

metal3d added 4 commits July 3, 2023 01:28

Bundle Adwaita icons (wip)

8310c1d

Renamed generator and use goreorder

2ebaeb0

Cleanup code, better doc

31c3026

More information about not defined Icons

91a3aa2

Not defined icons are set to the default. I don't have listed everything yet.

metal3d marked this pull request as draft July 2, 2023 23:47

metal3d added 5 commits July 3, 2023 09:14

Changed some icons, add others

eee44a3

Fix template usage

50d9a41

- prefer to use fully named properties in color struct - prefer to use template to `printf` elements intead of doing it in the functions

Fix docstring

a7b7131

Go generate comment should not be the first line

c0baa2d

metal3d marked this pull request as ready for review July 3, 2023 09:19

metal3d added 2 commits July 3, 2023 14:25

Fixup the color of selection and menu

083362f

Actually, Adwaita doesn't document everything - at this time I need to decide which is the closer color using the theme on GNOME and comparing with a Fyne application.

Jacalz self-requested a review July 12, 2023 20:15

metal3d added a commit to metal3d/scoreboard that referenced this pull request Aug 31, 2023

Use custom theme

831baa7

While fyne-io/fyne-x#68 is not merged, using my own repository to have Adwaita theme + icons.

Jacalz reviewed Oct 4, 2023

View reviewed changes

Remove the modified sizes

9d10482

metal3d requested a review from Jacalz October 5, 2023 22:12

Jacalz approved these changes Oct 6, 2023

View reviewed changes

andydotxyz merged commit d8fd8fd into fyne-io:master Oct 16, 2023
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Theme adwaita - icons and enhancements #68

Theme adwaita - icons and enhancements #68

metal3d commented Jul 2, 2023 •

edited

Loading

andydotxyz commented Jul 12, 2023

Jacalz commented Jul 12, 2023

andydotxyz commented Oct 4, 2023

Jacalz left a comment

metal3d commented Oct 5, 2023

Jacalz commented Oct 5, 2023

Jacalz commented Oct 5, 2023

metal3d commented Oct 5, 2023

Jacalz left a comment

Jacalz commented Oct 6, 2023

andydotxyz commented Oct 16, 2023

metal3d commented Oct 16, 2023 •

edited

Loading

metal3d commented Oct 16, 2023

Theme adwaita - icons and enhancements #68

Theme adwaita - icons and enhancements #68

Conversation

metal3d commented Jul 2, 2023 • edited Loading

andydotxyz commented Jul 12, 2023

Jacalz commented Jul 12, 2023

andydotxyz commented Oct 4, 2023

Jacalz left a comment

Choose a reason for hiding this comment

metal3d commented Oct 5, 2023

Jacalz commented Oct 5, 2023

Jacalz commented Oct 5, 2023

metal3d commented Oct 5, 2023

Jacalz left a comment

Choose a reason for hiding this comment

Jacalz commented Oct 6, 2023

andydotxyz commented Oct 16, 2023

metal3d commented Oct 16, 2023 • edited Loading

metal3d commented Oct 16, 2023

metal3d commented Jul 2, 2023 •

edited

Loading

metal3d commented Oct 16, 2023 •

edited

Loading