Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Login #74

Open
fynnfluegge opened this issue Jul 11, 2023 · 0 comments
Open

Add Github Login #74

fynnfluegge opened this issue Jul 11, 2023 · 0 comments
Labels
effort high feature

Comments

@fynnfluegge
Copy link
Owner

fynnfluegge commented Jul 11, 2023 •
edited
Loading

It should be possible to login with Github account.

Todos

  • create Github OAuth 2.0 App
  • add OpenID Identity Provider to Cognito UserPoolClient, since Github doesn't support Single Sign-On
  • add lambda function as proxy for access-token and user-info endpoints

Wrapper for these tasks https://github.com/TimothyJones/github-cognito-openid-wrapper
Good resource https://sst.dev/examples/how-to-add-github-login-to-your-cognito-user-pool.html
rohitg00 added a commit to rohitg00/rocketnotes that referenced this issue Oct 27, 2024
@rohitg00
Add Github login
280f0ef 
Related to fynnfluegge#74

Add Github login functionality to the application.

* **cdk/rocketnotes.go**
  - Add a new lambda function for Github OAuth 2.0 App.
  - Add OpenID Identity Provider to Cognito UserPoolClient.
  - Update the stack to include the new lambda function.

* **webapp/src/main.ts**
  - Add Github OAuth 2.0 App configuration to the `oauth` object.
  - Update `Auth.configure` to include Github as an identity provider.

* **webapp/src/aws-exports.js**
  - Add Github OAuth 2.0 App configuration to the `awsmobile` object.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/fynnfluegge/rocketnotes/issues/74?shareId=XXXX-XXXX-XXXX-XXXX).
This was referenced Oct 27, 2024
Open
Closed
rohitg00 added a commit to rohitg00/rocketnotes that referenced this issue Oct 28, 2024
@rohitg00
feat: Enhanced GitHub OAuth with User Profile Management
906b7cc 
- Added secure token exchange Lambda
- Added GitHub user info Lambda
- Added user profile management with DynamoDB
- Added logging middleware
- Updated CDK stack with new resources
- Removed client secret from frontend
- Fixed Go module structure

Closes fynnfluegge#74
Addresses security concerns from PR fynnfluegge#145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort high feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Enhanced GitHub OAuth with User Profile Management rohitg00/rocketnotes
1 participant
@fynnfluegge