Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [REQUEST] - Rich type completion for non trivial type parameters #110

Open
Oberacda opened this issue Oct 9, 2024 · 3 comments
Open
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@Oberacda
Copy link
Contributor

Oberacda commented Oct 9, 2024

Implementation PR

No response

Reference Issues

No response

Summary

We want custom-type classes for several options:

  • ROS Types
    • Services
    • Actions
    • Msgs
    • Topic Names
  • Paths
    • Subtrees (file:// and package://)
    • Filesystem Nodes (file://)

This will allow us to create better autocompletion in the Web UI

Basic Example

  • The Topic Subscriber node requests a ROS Message type, but the autocompletion allows all types, including basic Python types, to be references.
  • The subtree node has a pure text input for specifying the path of the subtree. A filebrowser to define this would be nice.

Drawbacks

This will require changeing all the type completion types, both in the UI and the Backend.

Unresolved questions

No response

@Oberacda Oberacda added enhancement New feature or request question Further information is requested labels Oct 9, 2024
@Oberacda Oberacda added this to the v0.2.x milestone Oct 9, 2024
@Oberacda Oberacda self-assigned this Oct 9, 2024
@Oberacda
Copy link
Contributor Author

Oberacda commented Oct 9, 2024

@nspielbau you think this makes sense?

@nspielbau
Copy link
Contributor

A filebrowser for subtrees sounds very helpful and good for usability.
While the type completion also sounds nice, we will need to be careful to not restrict Node Classes that want access to those primitive Python types as well as ROS interfaces e.g. GetAttr

@Oberacda
Copy link
Contributor Author

Related to #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants