Skip to content

Commit

Permalink
Merge branch 'schema-urgent-fixes' into aCollectionOf-property-fix
Browse files Browse the repository at this point in the history
  • Loading branch information
costero-e authored Dec 12, 2024
2 parents a729ef4 + d02c6bf commit 8d9715b
Show file tree
Hide file tree
Showing 157 changed files with 961 additions and 1,150 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

* Fixed `POST`queries for `g_variant` (w/ examples)
* Removed 'json' references inside the yaml version (PR [#43] (https://github.com/ga4gh-beacon/beacon-v2/pull/43))
* Removed 'json' references inside the yaml version (PR [#43](https://github.com/ga4gh-beacon/beacon-v2/pull/43))
* added missing `type: object` to `ResultsetInstance` (PR [#82](https://github.com/ga4gh-beacon/beacon-v2/pull/82))

### Deprecated

Expand Down
35 changes: 34 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,40 @@ As with other schema projects, here we separate between the schema source files

There is a set of tools in [`/bin`](./bin/) to facilitate the conversion. ATM, after editing `...yaml` schema files somewhere in the `/src` tree, a (local) run of `bin/yamlerRunner.sh` - which re-generates the `....json` files in the `/json` tree) has to be performed before pushing changes.

### Changes
### Changelog

## 2.1.1

*Released, October, 8, 2024*
[Beacon-v2.1.1](https://github.com/ga4gh-beacon/beacon-v2/tree/5ea17fbd0d2ba533aa1e85f7271f9a2cc9be6794)

* Changed uri for uri-template in Endpoint.singleEntryUrl


## 2.1.0

*Released, July, 19, 2024*
[Beacon-v2.1.0](https://github.com/ga4gh-beacon/beacon-v2/tree/16862205c79294fae5473f7fa330bf5929b3b120)

* Relocated TypedQuantity required to proper level of the schema for complexValue
* Added end and start entities for ageRange and iso8601duration for age
* Filtering terms scopes changed from string to array of strings

## 2.0.1

*Released July, 16, 2024*
[Beacon-v2.0.1](https://github.com/ga4gh-beacon/beacon-v2/tree/f6f85c445922831bd398552384593206c86287de)

* Replaced ENSGLOSSARY for SO ontology family in documentation examples
* Moved CURIE to beaconCommonComponents
* Created filtering terms entity
* Removed validation directories
* Several fixes to entity types, typos and other non-breaking changes

## 2.0.0

*Released June, 21, 2022*
[Beacon-v2.0.0](https://github.com/ga4gh-beacon/beacon-v2/tree/d07ef1626321f7428374a4f68d864dfa5e98370f)

* change notes with respect to the repository & documentation are now in [docs.genomebeacons.org](https://docs.genomebeacons.org/changes-todo/)
* NOTE: on 2022-06-20 the previous development repositories have been archived:
Expand Down
2 changes: 1 addition & 1 deletion bin/beaconYamler.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/local/bin/python3
#!/usr/bin/env python3

import sys, re, json
import pathlib
Expand Down
4 changes: 2 additions & 2 deletions bin/beacon_yaml2md.pl
Original file line number Diff line number Diff line change
Expand Up @@ -729,9 +729,9 @@ sub add_properties_vrs {
my ( $property, $data ) = @_;
my %url = (
'SequenceExpression' =>
'https://raw.githubusercontent.com/ga4gh/vrs/1.2/schema/vrs.json#/definitions/',
'https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/',
'CopyNumber' =>
'https://raw.githubusercontent.com/ga4gh/vrs/1.2/schema/vrs.json#/definitions/'
'https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/'
);
if ( exists $url{$property} ) {
$data->{properties} =
Expand Down
4 changes: 2 additions & 2 deletions bin/deref_schemas/biosamples/defaultSchema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ properties:
title: Value
type: object
- $schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down Expand Up @@ -1064,7 +1064,7 @@ properties:
description: List of phenotypic abnormalities of the sample. RECOMMENDED.
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down
8 changes: 4 additions & 4 deletions bin/deref_schemas/cohorts/defaultSchema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
$comment: 'version: ga4gh-beacon-cohort-v2.0.0'
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: &1 !!perl/scalar:JSON::PP::Boolean 1
definitions:
$defs:
CohortCriteria:
description: Criteria used for defining the cohort. It is assumed that all cohort participants will match or NOT match such criteria.
properties:
Expand Down Expand Up @@ -366,7 +366,7 @@ definitions:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down Expand Up @@ -1660,7 +1660,7 @@ properties:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down Expand Up @@ -2406,7 +2406,7 @@ properties:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/datasets/defaultSchema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ properties:
dataUseConditions:
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: 1
definitions:
$defs:
DUODataUse:
allOf:
- description: 'Data Use Ontology codes and additional information associated with a data object (e.g. sample, dataset).'
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/genomicVariations/defaultSchema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
$comment: 'version: ga4gh-beacon-variant-v2.0.0'
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: &1 !!perl/scalar:JSON::PP::Boolean 1
definitions:
$defs:
CaseLevelVariant:
description: ''
properties:
Expand Down
6 changes: 3 additions & 3 deletions bin/deref_schemas/individuals/defaultSchema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ properties:
title: Value
type: object
- $schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down Expand Up @@ -1299,7 +1299,7 @@ properties:
items:
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: 1
definitions:
$defs:
pedigreeMember:
examples:
- membersInProband:
Expand Down Expand Up @@ -1696,7 +1696,7 @@ properties:
phenotypicFeatures:
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/Complex Value.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
Complex Value:
$schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/CopyNumber.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
---
CopyNumber:
properties: '[VRS definition for CopyNumber](https://raw.githubusercontent.com/ga4gh/vrs/1.2/schema/vrs.json#/definitions/CopyNumber)'
properties: '[VRS definition for CopyNumber](https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/CopyNumber)'
type: allOf
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/dataUseConditions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
dataUseConditions:
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: 1
definitions:
$defs:
DUODataUse:
allOf:
- description: Data Use Ontology codes and additional information associated
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/exclusionCriteria.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ exclusionCriteria:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or
biosample.
properties:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/inclusionCriteria.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ inclusionCriteria:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or
biosample.
properties:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/measurementValue.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ measurementValue:
properties:
Complex Value:
$schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/measurements.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ measurements:
title: Value
type: object
- $schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/measures.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ measures:
title: Value
type: object
- $schema: https://json-schema.org/draft/2020-12/schema
definitions:
$defs:
TypedQuantity:
properties:
quantity:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/pedigrees.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ pedigrees:
items:
$schema: https://json-schema.org/draft/2020-12/schema
additionalProperties: 1
definitions:
$defs:
pedigreeMember:
examples:
- membersInProband:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/phenotypicConditions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ phenotypicConditions:
description: Phenotypic condition(s) in cohort inclusion criteria
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down
2 changes: 1 addition & 1 deletion bin/deref_schemas/obj/phenotypicFeatures.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
phenotypicFeatures:
items:
$schema: https://json-schema.org/draft/2020-12/schema
definitions: {}
$defs: {}
description: Used to describe a phenotype that characterizes the subject or biosample.
properties:
evidence:
Expand Down
15 changes: 0 additions & 15 deletions bin/yamlerRunner.sh
Original file line number Diff line number Diff line change
@@ -1,28 +1,13 @@
BASEDIR=$(dirname $0)
UNITYPATH=$BASEDIR/..

# initial conversion from separate schemas
# DEPRECATED
# BEACONMODELPATH=$BASEDIR/../../beacon-v2-Models/BEACON-V2-Model
# BEACONFRAMEWORKPATH=$BASEDIR/../../beacon-framework-v2

BEACONMODELNAME=beacon-v2-default-model

# for UPSTREAM in $BEACONMODELPATH $BEACONFRAMEWORKPATH
# do
# echo "pulling $UPSTREAM"
# git -C $UPSTREAM pull
# done

for KIND in src json
do
mkdir -p $UNITYPATH/models/$KIND/$BEACONMODELNAME
mkdir -p $UNITYPATH/framework/$KIND
done

# $BASEDIR/beaconYamler.py -i $BEACONMODELPATH -t json -x yaml -o $UNITYPATH/models/src/$BEACONMODELNAME
# $BASEDIR/beaconYamler.py -i $BEACONFRAMEWORKPATH -t json -x yaml -o $UNITYPATH/framework/src

# recurring conversion from the source files to the exported versions
$BASEDIR/beaconYamler.py -i $UNITYPATH/models/src/$BEACONMODELNAME -t yaml -x json -o $UNITYPATH/models/json/$BEACONMODELNAME
$BASEDIR/beaconYamler.py -i $UNITYPATH/framework/src -t yaml -x json -o $UNITYPATH/framework/json
2 changes: 1 addition & 1 deletion docs/schemas-md/obj/CopyNumber.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
|Term | Description | Type | Properties | Example | Enum|
| ---| ---| ---| ---| ---| --- |
| CopyNumber | NA | allOf | [VRS definition for CopyNumber](https://raw.githubusercontent.com/ga4gh/vrs/1.2/schema/vrs.json#/definitions/CopyNumber) | NA | NA|
| CopyNumber | NA | allOf | [VRS definition for CopyNumber](https://w3id.org/ga4gh/schema/vrs/1.3/vrs.json#/definitions/CopyNumber) | NA | NA|
Loading

0 comments on commit 8d9715b

Please sign in to comment.