Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating "definitions" (deprecated) to "$defs" in some Json schemas #153

Closed
jrambla opened this issue Jul 24, 2024 · 4 comments
Closed

Updating "definitions" (deprecated) to "$defs" in some Json schemas #153

jrambla opened this issue Jul 24, 2024 · 4 comments
Assignees

Comments

@jrambla
Copy link
Contributor

jrambla commented Jul 24, 2024

Some Json files include the "defnitions" element.
In Json schema '2020-12' it has been deprecated to "$defs".
VS Code validator, at least, is complaining about that.

@mbaudis should I edit the json version directly or should the source generator from YAML?
(I haven't spotted the place on it)

@mbaudis
Copy link
Member

mbaudis commented Jul 24, 2024

@jrambla I'll do. The "some" adds up since it's not only the definitions: but also the references to them e.g. #/definitions/ResultsetInstance ... I'll change & make a PR for review.

Re editing: Yes, YAML version and then local use of `bin/vamlerRunner.sh' which I wrote for locally performed schema conversion. It uses a function to keep the json parameters in order; when editing by hand this might lead to changed files which git wants to update then (purely due to changed order).

@jrambla
Copy link
Contributor Author

jrambla commented Sep 12, 2024

@mbaudis is this done and could we close the issue?

@mbaudis
Copy link
Member

mbaudis commented Sep 12, 2024

@jrambla This was addressed in #155 - but this hadn't been merged since missing a review ...

@costero-e
Copy link
Collaborator

Closing as this has been merged in #155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants