From edf561ed1a4c612efd3921beecbb5f6378c684f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20L=C3=B3pez-Doriga?= Date: Wed, 20 Mar 2024 16:02:44 +0100 Subject: [PATCH 1/2] filtering terms results example listed --- .../sections/beaconFilteringTermsResults.json | 2 +- .../sections/beaconFilteringTermsResults.yaml | 13 ++++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/framework/json/responses/sections/beaconFilteringTermsResults.json b/framework/json/responses/sections/beaconFilteringTermsResults.json index daaf0fc9..29a1761b 100644 --- a/framework/json/responses/sections/beaconFilteringTermsResults.json +++ b/framework/json/responses/sections/beaconFilteringTermsResults.json @@ -30,7 +30,7 @@ "type": "string" }, "scopes": { - "description": "Entry types this filter may be applied to.", + "description": "Entry types affected by this filter.", "examples": [ "[\"individual\", \"biosample\"]" ], diff --git a/framework/src/responses/sections/beaconFilteringTermsResults.yaml b/framework/src/responses/sections/beaconFilteringTermsResults.yaml index ff147435..5c4ddec4 100644 --- a/framework/src/responses/sections/beaconFilteringTermsResults.yaml +++ b/framework/src/responses/sections/beaconFilteringTermsResults.yaml @@ -48,9 +48,16 @@ definitions: - 'Aplasia/Hypoplasia of the middle ear' scopes: description: >- - Entry types this filter may be applied to. - examples: - - '["individual", "biosample"]' + Entry types affected by this filter. + examples: + - + - individual + - biosample + - analysis + - run + - genomicVariation + - + - biosample type: array items: type: string From 1447418ae20062d48c6644b705a4e0c31b8355af Mon Sep 17 00:00:00 2001 From: Dmitry Repchevsky Date: Wed, 20 Mar 2024 16:28:22 +0100 Subject: [PATCH 2/2] fix "examples" beaconFilteringTermsResults.json should be an array of arrays... --- .../json/responses/sections/beaconFilteringTermsResults.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/framework/json/responses/sections/beaconFilteringTermsResults.json b/framework/json/responses/sections/beaconFilteringTermsResults.json index 29a1761b..a821680e 100644 --- a/framework/json/responses/sections/beaconFilteringTermsResults.json +++ b/framework/json/responses/sections/beaconFilteringTermsResults.json @@ -32,7 +32,8 @@ "scopes": { "description": "Entry types affected by this filter.", "examples": [ - "[\"individual\", \"biosample\"]" + ["individual", "biosample", "analysis", "run", "genomicVariation"], + ["biosample"] ], "type": "array", "items": { @@ -114,4 +115,4 @@ } }, "type": "object" -} \ No newline at end of file +}