Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections response fix endpoints #121

Closed
wants to merge 6 commits into from
Closed

Collections response fix endpoints #121

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea3be85
fixing ResultsOKResponse for cohorts
mbaudis Mar 21, 2024
2553223
beaconCollectionsResponse
mbaudis Mar 21, 2024
ea4324b
ResultsetsResponse for cohorts/{id}/individuals
mbaudis Mar 22, 2024
1012bd9
fix remnants of resultsOKresponse => CollectionsResponse
mbaudis Mar 25, 2024
063cb8a
file case bug fix
mbaudis Mar 25, 2024
b854dc4
file case bug fix
mbaudis Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 3 additions & 23 deletions models/json/beacon-v2-default-model/cohorts/endpoints.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,26 +50,6 @@
}
},
"responses": {
"CollectionsResponse": {
"content": {
"application/json": {
"schema": {
"oneOf": [
{
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconBooleanResponse.json"
},
{
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconCountResponse.json"
},
{
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconCollectionsResponse.json"
}
]
}
}
},
"description": "Successful collection list operation."
},
"ResultsOKResponse": {
"content": {
"application/json": {
Expand All @@ -82,7 +62,7 @@
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconCountResponse.json"
},
{
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconResultsetsResponse.json"
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconCollectionsResponse.json"
}
]
}
Expand Down Expand Up @@ -126,7 +106,7 @@
],
"responses": {
"200": {
"$ref": "#/components/responses/CollectionsResponse"
"$ref": "#/components/responses/ResultsOKResponse"
},
"default": {
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconErrorResponse.json"
Expand All @@ -151,7 +131,7 @@
},
"responses": {
"200": {
"$ref": "#/components/responses/CollectionsResponse"
"$ref": "#/components/responses/ResultsOKResponse"
},
"default": {
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconErrorResponse.json",
Expand Down
26 changes: 3 additions & 23 deletions models/json/beacon-v2-default-model/datasets/endpoints.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,26 +48,6 @@
}
},
"responses": {
"CollectionsResponse": {
"content": {
"application/json": {
"schema": {
"oneOf": [
{
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconBooleanResponse.json"
},
{
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconCountResponse.json"
},
{
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconCollectionsResponse.json"
}
]
}
}
},
"description": "Successful collection list operation."
},
"ResultsOKResponse": {
"content": {
"application/json": {
Expand All @@ -80,7 +60,7 @@
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconCountResponse.json"
},
{
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconResultsetsResponse.json"
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconCollectionsResponse.json"
}
]
}
Expand Down Expand Up @@ -124,7 +104,7 @@
],
"responses": {
"200": {
"$ref": "#/components/responses/CollectionsResponse"
"$ref": "#/components/responses/ResultsOKResponse"
},
"default": {
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconErrorResponse.json"
Expand All @@ -149,7 +129,7 @@
},
"responses": {
"200": {
"$ref": "#/components/responses/CollectionsResponse"
"$ref": "#/components/responses/ResultsOKResponse"
},
"default": {
"$ref": "https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconErrorResponse.json",
Expand Down
21 changes: 7 additions & 14 deletions models/src/beacon-v2-default-model/cohorts/endpoints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ paths:
- GET Endpoints
responses:
'200':
$ref: '#/components/responses/CollectionsResponse'
$ref: '#/components/responses/ResultsOKResponse'
default:
$ref: https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconErrorResponse.json
post:
Expand All @@ -44,7 +44,7 @@ paths:
required: true
responses:
'200':
$ref: '#/components/responses/CollectionsResponse'
$ref: '#/components/responses/ResultsOKResponse'
default:
description: An unsuccessful operation
$ref: https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconErrorResponse.json
Expand Down Expand Up @@ -166,15 +166,6 @@ components:
responses:
ResultsOKResponse:
description: Successful operation.
content:
application/json:
schema:
oneOf:
- $ref: https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconBooleanResponse.json
- $ref: https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconCountResponse.json
- $ref: https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconResultsetsResponse.json
CollectionsResponse:
description: Successful collection list operation.
content:
application/json:
schema:
Expand All @@ -185,8 +176,9 @@ components:
parameters:
requestedSchema:
name: requestedSchema
description: Schema to be used to format the `result` field in the response.
The response will use Beacon format.
description: >-
Schema to be used to format the `result` field in the response.
The response will use the Beacon format.
in: query
required: false
schema:
Expand Down Expand Up @@ -216,4 +208,5 @@ components:
items:
type: string
examples:
- - OMIABIS:0001017
-
- OMIABIS:0001017
13 changes: 2 additions & 11 deletions models/src/beacon-v2-default-model/datasets/endpoints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ paths:
- GET Endpoints
responses:
'200':
$ref: '#/components/responses/CollectionsResponse'
$ref: '#/components/responses/ResultsOKResponse'
default:
$ref: https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconErrorResponse.json
post:
Expand All @@ -44,7 +44,7 @@ paths:
required: true
responses:
'200':
$ref: '#/components/responses/CollectionsResponse'
$ref: '#/components/responses/ResultsOKResponse'
default:
description: An unsuccessful operation
$ref: https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconErrorResponse.json
Expand Down Expand Up @@ -240,15 +240,6 @@ components:
responses:
ResultsOKResponse:
description: Successful operation.
content:
application/json:
schema:
oneOf:
- $ref: https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconBooleanResponse.json
- $ref: https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconCountResponse.json
- $ref: https://raw.githubusercontent.com/ga4gh-beacon/beacon-v2/main/framework/json/responses/beaconResultsetsResponse.json
CollectionsResponse:
description: Successful collection list operation.
content:
application/json:
schema:
Expand Down
Loading