Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting breaks keyboard navigation and group selection #1

Open
gabbard opened this issue Jan 24, 2020 · 2 comments
Open

Sorting breaks keyboard navigation and group selection #1

gabbard opened this issue Jan 24, 2020 · 2 comments

Comments

@gabbard
Copy link
Owner

gabbard commented Jan 24, 2020

To reproduce, trigger the sort with Ctrl-D. Then attempt to navigate the tasks by the keyboard. The navigation will hop around in the original order.

Unfortunately, in the Chrome Developer view I don't see any obvious ordering identifier associated with the items, so this might not be a quick fix.

@gabbard
Copy link
Owner Author

gabbard commented Jan 24, 2020

Aha, it is possible an ID is attached to a node without appearing in the HTML source. There are various references to IDs on nodes in the Javascript code, including id, global_id, and itemId. I should check whether any of these are attached to the relevant nodes.

@gabbard
Copy link
Owner Author

gabbard commented Jan 24, 2020

This (from bundle.js from the Asana Javascript) looks like a promising clue:

selectedEntryInfo: computedProperty("selectedEntryInfoR", function() {
            var e = this;
            return knownReturnValueOrDefault(function() {
                if ($v(e.selection_enabled_r)) {
                    var t = e.deserializedEntryInfo()
                      , n = $v(e.list_sections_x);
                    if (zt.ne(void 0, t, "Expected selected_entry_info != undefined"),
                    null !== t) {
                        var r = e._entryByIdInSection(n, t.get("section_id"), t.get("entry_id"));
                        if (r)
                            return t
                    }
                    return e._defaultSelectionInfo(!1)
                }
                return null
            }, null)
        }),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant