Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query parameter are not supported #24

Open
sammeel opened this issue Apr 5, 2016 · 1 comment
Open

query parameter are not supported #24

sammeel opened this issue Apr 5, 2016 · 1 comment

Comments

@sammeel
Copy link

sammeel commented Apr 5, 2016

Hey

When we use query parameters and we don't have a trailing slash to the path, we will get a page not found.

I've been able to reproduce this in the example on http://gabrielmoreira.github.io/riot-router/examples/example-01.html

When you would go to the url http://gabrielmoreira.github.io/riot-router/examples/example-01.html#/about?something
then you get a page not found.

but this url will work (with trailing slash): http://gabrielmoreira.github.io/riot-router/examples/example-01.html#/about/?something

Could you have a look at this?
Thanks in advance.

@gabrielmoreira
Copy link
Owner

Hi Sammeel , i'm on vacation. When i return i will look it.
Em 05/04/2016 13:59, "sammeel" [email protected] escreveu:

Hey

When we use query parameters and we don't have a trailing slash to the
path, we will get a page not found.

I've been able to reproduce this in the example on
http://gabrielmoreira.github.io/riot-router/examples/example-01.html

When you would go to the url
http://gabrielmoreira.github.io/riot-router/examples/example-01.html#/about?something
then you get a page not found.

but this url will work (with trailing slash):
http://gabrielmoreira.github.io/riot-router/examples/example-01.html#/about/?something

Could you have a look at this?
Thanks in advance.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#24

gabrielmoreira pushed a commit that referenced this issue Jul 20, 2016
- Fix umd module
- Fix hasOwnProperty #25
- Support query parameters #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants