Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #42
Translates
countdown()
andcountdown_style()
over to Python.Also includes a restriction so that language-specific CI runs only when files in
r/
orpython/
change.We currently have:
I'm not sure if there is an issue with how the
HTMLDependency()
is being registered; but, the countdown at the moment renders but is not clickable with.show()
(I think this is the same asbrowsable()
).I pieced together the changes needed by looking at:
Some useful examples of
py-htmltools
are over onpy-shiny
's website:Note: Tags in
shiny.ui
are just re-exports fromhtmltools
: https://github.com/posit-dev/py-shiny/blob/6f4bf63b85587c7de2712505dc65a91036ec34a1/shiny/ui/__init__.py#L327-L356