Windows fullscreen fix #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes i just saw your repo, nice work! |
|
Thanks! Yes indeed I plan to continue working on my fork for at least a few months on personal features I would like to add, then I would also love to implement / fix bugs raised by the community. |
|
I close this due to inactivity, and I already implemented this fix, as well as new features on Manim Slides. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes a small fix to the problem where full-screen resolution is bad. Apparently, this only occurs in Windows platforms.
Tested on Windows 10 & Ubuntu 22.04. The solution is mostly a copy / paste from here.
Even though, the fix is not a perfect fix and quality is still not as good as with Ubuntu. For instance, I had to render in
por evenkquality on Windows to have a result similar tohquality on Ubuntu.As mentioned in #15, I am working on a separate fork on which I did other improvements, and many more improvements are still ongoing. Maybe we could merge both works later, or I can keep me work separate as it implies some major changes in the codebase.
Anyway, this is not the point of this PR :-)
Closes #15.