Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows fullscreen fix #19

Closed

Conversation

jeertmans
Copy link

This proposes a small fix to the problem where full-screen resolution is bad. Apparently, this only occurs in Windows platforms.
Tested on Windows 10 & Ubuntu 22.04. The solution is mostly a copy / paste from here.

Even though, the fix is not a perfect fix and quality is still not as good as with Ubuntu. For instance, I had to render in p or even k quality on Windows to have a result similar to h quality on Ubuntu.

As mentioned in #15, I am working on a separate fork on which I did other improvements, and many more improvements are still ongoing. Maybe we could merge both works later, or I can keep me work separate as it implies some major changes in the codebase.
Anyway, this is not the point of this PR :-)

Closes #15.

@galatolofederico
Copy link
Owner

Yes i just saw your repo, nice work!
If you plan to continue working/support your fork i will deprecate this repo and link to yours

@jeertmans
Copy link
Author

Thanks! Yes indeed I plan to continue working on my fork for at least a few months on personal features I would like to add, then I would also love to implement / fix bugs raised by the community.

@jeertmans
Copy link
Author

I close this due to inactivity, and I already implemented this fix, as well as new features on Manim Slides.

@jeertmans jeertmans closed this Sep 14, 2022
@jeertmans jeertmans deleted the windows-fullscreen-fix branch September 14, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad quality of presentation with --fullscreen flag
2 participants