Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on_string for collections selected in multiple=true inputs #7467

Open
bernt-matthias opened this issue Mar 5, 2019 · 3 comments · May be fixed by #19817
Open

on_string for collections selected in multiple=true inputs #7467

bernt-matthias opened this issue Mar 5, 2019 · 3 comments · May be fixed by #19817

Comments

@bernt-matthias
Copy link
Contributor

If a collection is chosen in a multiple=true input field the on_string for generated data sets is different to the case if input is a collection. Reminds me on #7392

I think it should be tool name on collection xyz in both cases. instead of ... on data a and data b...
@bernt-matthias
Copy link
Contributor Author

At least documented/discussed now in the docs now: galaxyproject/planemo#930

@nsoranzo nsoranzo mentioned this issue May 6, 2019
Merged
@mvdbeek
Copy link
Member

mvdbeek commented May 6, 2019

This is fixable (_get_on_text in

galaxy/lib/galaxy/tools/actions/__init__.py

Line 292 in 0b8dec5

on_text = self._get_on_text(inp_data)
would just also need to look at inp_dataset_collection), but I'm hoping we can get rid of the reference to hids (=data N ) altogether. If no explicit name is set we could just compute that string on the fly since we know the input datasets and we know the tool that was used to produce the dataset. If we did that the references would remain intact even if copied to a different history.

@bernt-matthias
Copy link
Contributor Author

This would be great.

@bernt-matthias bernt-matthias mentioned this issue Aug 6, 2019
Open
@bernt-matthias bernt-matthias mentioned this issue Mar 12, 2021
Closed
@bernt-matthias bernt-matthias mentioned this issue Dec 2, 2024
Closed
4 tasks
@bernt-matthias bernt-matthias linked a pull request Mar 15, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mvdbeek @bernt-matthias