Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT,FIX github actions #33

Merged
merged 5 commits into from
Jul 29, 2024
Merged

MNT,FIX github actions #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0b33e6
MNT remove flake8
mvdoc Jul 29, 2024
621e690
Revert back to linting with flake but ensure that sphinx is installed
mvdoc Jul 29, 2024
75369c9
FIX use instead of
mvdoc Jul 29, 2024
41e8dad
FIX use sudo
mvdoc Jul 29, 2024
d1e8a34
Remove flake for good
mvdoc Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/run_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,6 @@ jobs:
pip install -q -r test_requirements.txt
pip install -e .

- name: Lint with flake8
run: |
pip install -q flake8
# stop the build if there are Python syntax errors or undefined names
flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
flake8 . --count --exit-zero --ignore=E402,C901 --max-line-length=127 --statistics

- name: Test with pytest
run: |
pytest -v --cov=./
Expand Down
4 changes: 2 additions & 2 deletions moten/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def raw_project_stimulus(stimulus,
# checks for 2D stimuli
assert stimulus.ndim == 2 # (nimages, pixels)
assert isinstance(vhsize, tuple) and len(vhsize) == 2 # (hdim, vdim)
assert np.product(vhsize) == stimulus.shape[1] # hdim*vdim == pixels
assert np.prod(vhsize) == stimulus.shape[1] # hdim*vdim == pixels

# Compute responses
nfilters = len(filters)
Expand Down Expand Up @@ -103,7 +103,7 @@ def project_stimulus(stimulus,
# checks for 2D stimuli
assert stimulus.ndim == 2 # (nimages, pixels)
assert isinstance(vhsize, tuple) and len(vhsize) == 2 # (hdim, vdim)
assert np.product(vhsize) == stimulus.shape[1] # hdim*vdim == pixels
assert np.prod(vhsize) == stimulus.shape[1] # hdim*vdim == pixels

# Compute responses
nfilters = len(filters)
Expand Down