Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory use #10

Open
lsmith77 opened this issue Nov 9, 2022 · 2 comments
Open

memory use #10

lsmith77 opened this issue Nov 9, 2022 · 2 comments

Comments

@lsmith77
Copy link

lsmith77 commented Nov 9, 2022

I am running into issues with memory use as I integrated your solution into an API.

Now I am pondering ways to reduce memory use and increase scalability. One idea I have is to move all these mappings into Redis. In theory this way I could load all of this into memory only once regardless of how many workers I have. As long as Redis manages to hold up and not introduce too much latency, this could in theory be a very memory efficient solution.

I need to implement this first but the question is if you would accept a PR that would optionally use Redis?

@gambolputty
Copy link
Owner

Hello! I only see a blank page when I click your link.

Interesting question, though. Did you find out what caused high memory usage/ why it did not scale?

I think redis would be too much for this small package. Another person suggested using SQLite (#6) and I think this would be the way to go. It's superfast and doesn't operate on a different process. Since there are no writing processes, even better.

@lsmith77
Copy link
Author

lsmith77 commented Jan 2, 2023

yeah that could be interesting ..

it would also allow for fallback logic ..

f.e. if “Lehrperson” is missing, you could look for “ehrperson”, “hrperson”, “person”. this is something I have implemented as well already.

note this strategy can lead to false positives. f.e. “arbeitende” would lead to “ende”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants