We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When discussing the Phong.fragshader the book mentions using clamp to limit the Phong RGB components to the 0.0-1.0 range.
Phong.frag
clamp
The actual clamp call seems to be missing from the shader code, however: https://github.com/gameprogcpp/code/blob/master/Chapter06/Shaders/Phong.frag
Adding this, the visual result is markedly different:
Phong = clamp(Phong, 0.0, 1.0);
The text was updated successfully, but these errors were encountered:
Good catch, I actually don't remember whether that's intentional or if it was a mistake!
Sorry, something went wrong.
No branches or pull requests
When discussing the
Phong.frag
shader the book mentions usingclamp
to limit the Phong RGB components to the 0.0-1.0 range.The actual
clamp
call seems to be missing from the shader code, however:https://github.com/gameprogcpp/code/blob/master/Chapter06/Shaders/Phong.frag
Adding this, the visual result is markedly different:
The text was updated successfully, but these errors were encountered: