Remove FileSystemContract.size(), which was never used as an interfac…

…e method
gammerce · May 31, 2022 · 6c2f999 · 6c2f999
1 parent 9226575
commit 6c2f999
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 19 deletions.
diff --git a/includes/Support/FileSystem.php b/includes/Support/FileSystem.php
@@ -3,6 +3,7 @@
 
 use ErrorException;
 use Exception;
+use function filesize;
 use function is_file;
 
 class FileSystem implements FileSystemContract
@@ -54,7 +55,7 @@ public function sharedGet($path)
             try {
                 if (flock($handle, LOCK_SH)) {
                     clearstatcache(true, $path);
-                    $contents = fread($handle, $this->size($path) ?: 1);
+                    $contents = fread($handle, filesize($path) ?: 1);
                     flock($handle, LOCK_UN);
                 }
             } finally {
@@ -69,11 +70,6 @@ public function isDirectory($path)
         return is_dir($path);
     }
 
-    public function size($path)
-    {
-        return filesize($path);
-    }
-
     public function append($file, $text)
     {
         if ($this->exists($file) && strlen($this->get($file))) {

diff --git a/includes/Support/FileSystemContract.php b/includes/Support/FileSystemContract.php
@@ -65,14 +65,6 @@ public function sharedGet($path);
      */
     public function isDirectory($path);
 
-    /**
-     * Get the file size of a given file.
-     *
-     * @param  string $path
-     * @return int
-     */
-    public function size($path);
-
     /**
      * Add text to the end of the file
      *

diff --git a/tests/Psr4/MemoryFileSystem.php b/tests/Psr4/MemoryFileSystem.php
@@ -75,11 +75,6 @@ public function isDirectory($path)
         return $this->exists($formattedPath) && $this->fileSystem[$formattedPath]["type"] === "d";
     }
 
-    public function size($path)
-    {
-        return $this->exists($path) ? 1 : 0;
-    }
-
     public function append($file, $text)
     {
         if ($this->exists($file) && strlen($this->get($file))) {