Move to unversioned python and add documentation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinecraftServer is Depreciated and will be removed in 2022-08
Fix Errors on Readme
Update to Python 3.9 on RHEL
Handle the expection so the template can recognize it as offline
Fix typo
Fix error
Add Trigger for Server Down
remove uuids
Fix so that old and new mcstatus is supported
Remove test python3.9 dependency and add example
Change name and update descriptions
Fix Template
Fixed typo
Fixed typo
Changed to Python3
| # Get server instance | ||
| server = MinecraftServer(sys.argv[2], int(sys.argv[3])) | ||
| try: |
There was a problem hiding this comment.
I also made changes to implement the new mcstatus "JavaServer" class as well as the old one.
There was a problem hiding this comment.
This should also fix #4
| @@ -34,6 +34,13 @@ | |||
| <name>Minecraft</name> | |||
| </application> | |||
| </applications> | |||
| <triggers> | |||
There was a problem hiding this comment.
It also has a trigger that can notify you if a server goes offline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these changes over the last few years while running a few minecraft servers for me and my friends.
Apparently i haven't made a PR yet.
The commits are somewhat crappy since I was debugging issues inside github and then pulling it onto the servers ^^