Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop and ruby version 1.8.7 incompatible #101

Open
witjoh opened this issue Dec 3, 2015 · 2 comments
Open

rubocop and ruby version 1.8.7 incompatible #101

witjoh opened this issue Dec 3, 2015 · 2 comments

Comments

@witjoh
Copy link
Contributor

witjoh commented Dec 3, 2015

rubocop depends in rainbow, which requires ruby version 1.9.2
Travis tests with ruby 1.8.7 does not work because of this.
In the skeleton, ruby 1.8.7 is still configured in the travis.yml

And puppet 3.x/ruby 1.8.7 is still used in many places.

Any thoughts how this could be solved ?
Exclude rubocop when working with ruby version 1.8.7 ?
(rubicop v0.6.1 seems the latest version running on 1.8.7)

@garethr
Copy link
Owner

garethr commented Dec 3, 2015

I'd be happy to see a patch for this, it's a known problem with the defaults (see b1c5f35). I think the main think is the the skeleton once generated is designed to be edited.

@witjoh
Copy link
Contributor Author

witjoh commented Dec 3, 2015

As it seems playing a bit more with the skeleton and trying to support all ruby versions from 1.8.7 up,
almost everything is broken when running in 1.8.7 ruby.
I'm for removing 1.8.7 ruby version from the skeleton. At least the defaults it provides will work (in most cases).
I managed to exclude ruboconf when using 1.8.7, but then other issues arise. And I don't see an easy fix for all of them.
Only the .travis.yml should be patched.

But that also means puppet 2.7 is not supported by the skeleton ...
Better then is to comment them out (with a short explanation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants