-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export plugin path in cmake so that we dont need to rely on ament/dsvs #185
Comments
I'll just add some links here as reference:
I believe technically this is not true, I think ament is meant to be a project upstream of ROS 2, even though it is tightly connected to it. The main difficulty for us to use it for Ignition may be that it isn't released for the platforms we care about.
I think it's a good idea to provide convenient macros, but I'd like to point out that
I think the macros could be very valuable if they automatically installed the resources to standard places and generated the hook from that. For example:
I think that some documentation and examples may go a long way here. The work needed to generate and install the hooks is just 2 commands:
As a reference, here's an example of a pure CMake package that generates a hook:
We could add an example like that to |
This issue has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/gsoc-2022-tools-for-creating-new-ignition-projects/1321/1 |
I wanted to work on this issue.I think we can have the following macros- |
I had previously contributed on a pull request on the ros_ign repository. What more steps should I follow for the "Tools for creating new ignition projects" project in GSOC 2022? I commented here as this issue is related to the project that I mentioned. |
Hi @Aryaman22102002, glad to see your interest. As @harshmahesheka also wants to work on this for GSoC there are two ways to proceed:
|
Desired behavior
A few weeks ago, @luca-della-vedova and I were having a chat about external projects that create custom plugins and worlds. We probably should add an
export_plugin
andinstall_model_path
to make it easier for people to build colcon projects that rely on custom out of tree plugins. Currently, most packages either rely onament
or on colcon hooks to solve this problem. While ament is one solution, it does require that the project also be dependent on ros2. Colcon hooks, while very powerful are relatively undocumented and cumbersome to use as it requires multiple files. Ideally these macros would generate the desired hooks and export the correctIGN_GAZEBO_RESOURCE_PATH
,IGN_GAZEBO_SYSTEM_PLUGIN_PATH
and maybe evenIGN_LAUNCH_*_PATH
.Alternatives considered
One alternative is to set up a template repo with hooks and push the management downstream to users
The text was updated successfully, but these errors were encountered: