Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect app.ignitionrobotics.org URLs to corresponding fuel.ignitionrobotics.org resources #216

Open
chapulina opened this issue Nov 15, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@chapulina
Copy link
Contributor

When a user navigates to a model on the Fuel UI, for example:

https://app.ignitionrobotics.org/OpenRobotics/fuel/models/Double%20pendulum%20with%20base

There's a button on the top-right to copy the SDF snippet to download that model, which provides a corresponding URL in fuel.ignitionrobotics.org. There are a few problems with it:

  • I suspect not many users have found that button
  • The pre-filled SDF snippet is not always convenient, because users may already have a snippet to plug the URL into, or they're using another tool, like ign fuel

It would be very convenient to be able to use the URL from the web UI with SDF and other tools. That URL is immediately available to users navigating the site.

This also has the benefit that users looking at an SDF file can easily get to the web UI for the model.

Desired behavior

I want to be able to do:

ign fuel download -u "https://app.ignitionrobotics.org/OpenRobotics/fuel/models/Double pendulum with base"

And

<include>
<uri>
https://app.ignitionrobotics.org/OpenRobotics/fuel/models/Double pendulum with base
</uri>
</include>

Alternatives considered

Add a bunch more documentation on both the site and the tools about how to convert one URL to the other (i.e. #215 )

Implementation suggestion

Looking at the differences between the URLS:

https://fuel.ignitionrobotics.org/1.0/OpenRobotics/models/Double pendulum with base

https://app.ignitionrobotics.org/OpenRobotics/fuel/models/Double pendulum with base

Besides the different scheme (i.e. where fuel goes), the only real difference is the API version (1.0). This should be available to FuelClient, so I think it has all the necessary pieces to make the conversion at runtime when it receives an app.ignitionrobotics.org URL.

We'll need to hardcode that URL somewhere. I think it could be configurable through ~/.ignition/fuel/config.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant