Unify Python3_Development_FOUND checks (#662)

The value of this variable may change if other code paths call find_package(Python3), so move the warning to be co-located with the add_subdirectory call. Signed-off-by: Steve Peters <[email protected]>
gazebosim · Feb 12, 2025 · 62957f7 · 62957f7
1 parent 585c190
commit 62957f7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -103,9 +103,6 @@ else()
     COMPONENTS Interpreter
     OPTIONAL_COMPONENTS Development
   )
-  if (NOT Python3_Development_FOUND)
-    GZ_BUILD_WARNING("Python development libraries are missing: Python interfaces are disabled.")
-  endif()
 endif()
 
 # Location of "fake install folder" used in tests

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -18,8 +18,12 @@ gz_build_tests(TYPE UNIT SOURCES ${gtest_sources})
 add_subdirectory(graph)
 
 # Bindings subdirectories
-if (Python3_Development_FOUND AND NOT SKIP_PYBIND11)
-  add_subdirectory(python_pybind11)
+if (NOT SKIP_PYBIND11)
+  if (Python3_Development_FOUND)
+    add_subdirectory(python_pybind11)
+  else()
+    message(WARNING "Python development libraries are missing: Python interfaces are disabled.")
+  endif()
 endif()
 
 if (SWIG_FOUND AND NOT SKIP_SWIG)