Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Address Sanitizers on CI #370

Open
chapulina opened this issue Jan 25, 2022 · 2 comments
Open

Running Address Sanitizers on CI #370

chapulina opened this issue Jan 25, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@chapulina
Copy link
Contributor

There's currently some ongoing work to clean up ASAN warnings on Ignition Math. In order not to introduce regressions in the future, we should set up CI that runs ASAN periodically.

Desired behavior

ASAN is run periodically and its status is tracked by the build farmer.

Alternatives considered

People could keep running it manually...

Implementation suggestion

The current idea is to:

Most of the work should go into ign-cmake, and we may create a new GitHub action on https://github.com/ignition-tooling, similar to https://github.com/ignition-tooling/action-ignition-ci, or add a parameter to the existing action that enables ASAN.

Additional context

We considered using colcon's sanitizers like we have explained in our contribution guide, but decided for an ign-cmake native approach so this can be run without colcon.

@chapulina chapulina added the enhancement New feature or request label Jan 25, 2022
@j-rivero
Copy link
Contributor

ASAN builds are already running on our buildfarm https://build.osrfoundation.org/view/asan/. I'm waiting for the buildfarmer dashboard to include them https://github.com/osrf/buildfarmer/pull/304 but the task can consider done.

@j-rivero
Copy link
Contributor

Blocked by gazebo-tooling/release-tools#820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants