Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instruction regarding python tests #441

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 20, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#915

Summary

Python tests require make install.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from caguero as a code owner September 20, 2023 15:49
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #441 (3bd5f65) into gz-transport13 (d92aed2) will not change coverage.
Report is 1 commits behind head on gz-transport13.
The diff coverage is n/a.

❗ Current head 3bd5f65 differs from pull request most recent head 57d2df8. Consider uploading reports for the commit 57d2df8 to get more accurate results

@@               Coverage Diff               @@
##           gz-transport13     #441   +/-   ##
===============================================
  Coverage           87.76%   87.76%           
===============================================
  Files                  59       59           
  Lines                5696     5696           
===============================================
  Hits                 4999     4999           
  Misses                697      697           

@azeey azeey merged commit 19f642d into gz-transport13 Sep 28, 2023
7 checks passed
@azeey azeey deleted the azeey-patch-1 branch September 28, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants