Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old IGN reference #519

Closed
wants to merge 1 commit into from
Closed

Remove old IGN reference #519

wants to merge 1 commit into from

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Aug 9, 2024

Summary

Remove an old IGN reference.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero
Remove IGN reference.
5a84002 
Signed-off-by: Carlos Agüero <[email protected]>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 9, 2024
iche033
iche033 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also forward port to get the changes from #515

@caguero
Copy link
Collaborator Author

caguero commented Aug 9, 2024

we could also forward port to get the changes from #515

Oh, that's right, I forgot about it. I'll forward port it.

@caguero caguero closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caguero @iche033