Include what you use

Signed-off-by: Michael Carroll <[email protected]>

BUILD.bazel

@@ -12,7 +12,7 @@ package(
     features = GZ_FEATURES,
 )
 
-licenses(["notice"])  # Apache-2.0
+licenses(["notice"])
 
 exports_files(["LICENSE"])
 

cli/include/gz/utils/cli/GzFormatter.hpp

@@ -19,13 +19,15 @@
 #define GZ_UTILS_CLI_GZ_FORMATTER_HPP_
 
 #include <algorithm>
+#include <iterator>
 #include <string>
 #include <sstream>
 #include <vector>
 #include <unordered_map>
 
 #include "gz/utils/cli/App.hpp"
 #include "gz/utils/cli/FormatterFwd.hpp"
+#include "gz/utils/cli/StringTools.hpp"
 #include "gz/utils/Export.hh"
 
 //////////////////////////////////////////////////

src/Environment.cc

@@ -18,8 +18,7 @@
 #include <gz/utils/Environment.hh>
 
 #include <cstdlib>
-#include <iostream>
-
+#include <string>
 
 namespace gz
 {

src/Environment_TEST.cc

@@ -19,6 +19,8 @@
 
 #include <gz/utils/Environment.hh>
 
+#include <string>
+
 using namespace gz;
 
 /////////////////////////////////////////////////

src/NeverDestroyed_TEST.cc

@@ -19,7 +19,12 @@
 
 #include <gtest/gtest.h>
 
+#include <cstdint>
+#include <exception>
+#include <initializer_list>
 #include <random>
+#include <string>
+#include <vector>
 #include <unordered_map>
 
 using namespace gz;

test/integration/implptr/ImplPtr_TEST.cc

@@ -17,9 +17,10 @@
 
 #include <gtest/gtest.h>
 
-#include <gz/utils/ImplPtr.hh>
 #include "implptr_test_classes.hh"
 
+#include <utility>
+
 using namespace gz::implptr_test_classes;
 
 /////////////////////////////////////////////////

test/integration/implptr/implptr_test_classes.cc

@@ -17,6 +17,8 @@
 
 #include "implptr_test_classes.hh"
 
+#include <gz/utils/ImplPtr.hh>
+
 #include <string>
 #include <thread>
 
@@ -153,4 +155,3 @@ void CopyableObjectAlt::SetString(const std::string &_value)
 {
   (*dataPtr).svalue = _value;
 }
-

test/integration/implptr/implptr_test_classes.hh

@@ -42,7 +42,7 @@ namespace gz
       public: int GetInt() const;
 
       /// \brief Set the int value held by the pimpl
-      public: void SetInt(const int _value);
+      public: void SetInt(int _value);
 
       /// \brief Get the string value held by the pimpl
       public: const std::string &GetString() const;
@@ -72,7 +72,7 @@ namespace gz
       public: int GetInt() const;
 
       /// \brief Set the int value held by the pimpl
-      public: void SetInt(const int _value);
+      public: void SetInt(int _value);
 
       /// \brief Get the string value held by the pimpl
       public: const std::string &GetString() const;
@@ -102,7 +102,7 @@ namespace gz
       public: int GetInt() const;
 
       /// \brief Set the int value held by the pimpl
-      public: void SetInt(const int _value);
+      public: void SetInt(int _value);
 
       /// \brief Get the string value held by the pimpl
       public: const std::string &GetString() const;