Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: RFCs and the contribution process #7

Open
3 tasks
LunarLambda opened this issue Apr 15, 2021 · 2 comments
Open
3 tasks

RFC: RFCs and the contribution process #7

LunarLambda opened this issue Apr 15, 2021 · 2 comments
Labels

Comments

@LunarLambda
Copy link

(insert inception noise here)

Questions

  • Should the RFC process itself be documented? I think most importantly an issue template would be good so all the important information gets included from the get-go (checklist of questions, related/blocking RFCs, time estimate for resolution, so on), but also how and when we decide to resolve

  • What should the editing, review and contribution process look like? I think Pull Requests are the way to go, since it lets us make use of GitHub's review features, and hopefully prevents merge disasters.

    • Should PRs always be done against a new branch, and disallow committing to the main branch directly?
@Lokathor
Copy link
Contributor

I seriously doubt we'll have so much activity that we need to complicate this. Perhaps a little more near the startup, but after that it'll be small and infrequent changes.

just PR and merge to main branch, and then have commits to main trigger a github actions to update the github pages.

@avivace
Copy link
Member

avivace commented Apr 15, 2021

+1 for documenting the contribution process (commit messages, branches, permissions, reviews, ...), not so sure about the RFCc process. It may be overkill for now

@avivace avivace added the meta label Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants