Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic versioning #95

Open
avivace opened this issue Aug 27, 2021 · 1 comment
Open

Basic versioning #95

avivace opened this issue Aug 27, 2021 · 1 comment

Comments

@avivace
Copy link
Member

avivace commented Aug 27, 2021

No description provided.

@avivace avivace added the schema label Aug 27, 2021
@avivace avivace added this to the Schema Draft 4 milestone Jan 23, 2022
avivace added a commit that referenced this issue Jan 24, 2022
@avivace avivace linked a pull request Jan 25, 2022 that will close this issue
@avivace avivace changed the title Versioning Basic versioning Jan 25, 2022
@dag7dev
Copy link
Contributor

dag7dev commented May 2, 2022

While cleaning, I think the safest and less intrusive we have to do this is to implement the "field" version, for each file.
It should be a string, so we can include points and characters like a,b... for alpha,beta... versions
Additionally, same software in different folders can be merged into just one folder, and we would just need to add the missing information to the game.json

To understand what I mean here it is an example.

What's up right now:

{
    "default": true,
    "filename": "infinity.gb",
    "hash": {
        "md5": "6d6507bd38c76a9baa90b8e305ebea13",
        "sha1": "fdfd6d4cbebbf64fc7d1264f0450be270be89823",
        "sha256": "a5c7b34dbc1a6be0c2ec7ff5943f0e2bef24de9e9624d06604e7d60971a94330"
    },
    "playable": true
}

Proposal of change:

{
    "default": true,
    "filename": "infinity.gb",
    "version": "1.0.0",
    "hash": {
        "md5": "6d6507bd38c76a9baa90b8e305ebea13",
        "sha1": "fdfd6d4cbebbf64fc7d1264f0450be270be89823",
        "sha256": "a5c7b34dbc1a6be0c2ec7ff5943f0e2bef24de9e9624d06604e7d60971a94330"
    },
    "playable": true
}

@avivace avivace removed this from the Schema Draft 4 milestone Mar 5, 2024
@avivace avivace added this to the Game Entry Schema Draft 5 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants