Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordering by release date #84

Open
avivace opened this issue Jul 17, 2022 · 2 comments
Open

Add ordering by release date #84

avivace opened this issue Jul 17, 2022 · 2 comments
Assignees

Comments

@avivace
Copy link
Member

avivace commented Jul 17, 2022

Add the possibility to order results by release date.

How should entries without a release date be treated? Use the date of the commit that introduced them in the database?

@rnegron
Copy link
Contributor

rnegron commented Jul 28, 2022

I think a good first step is calculating how many entries don't have a release date. If there's not that many, it could be worth to try and manually find release dates (or estimates) and contribute these to the database. Otherwise, I would consider having the release date as null as having them appear at the end, sorted by title or similar.

@avivace
Copy link
Member Author

avivace commented Jul 29, 2022

I think a good first step is calculating how many entries don't have a release date. If there's not that many, it could be worth to try and manually find release dates (or estimates) and contribute these to the database. Otherwise, I would consider having the release date as null as having them appear at the end, sorted by title or similar.

Let me clarify this a bit:

  • This issue is about adding the functionality on the API to sort by the release date field, which is something well defined in the game schema. Nothing more, no populating or inputting data involved.
  • A lot (probably most) of the entries have no release date set in their game.json in the database repository. "To try and manually find release dates" is a major task that requires a huge commitment. What we could do there is open some kind of issues to promote this type of work, on the database repository.
  • My suggestion here was to add an additional field (which can be computed from the database git data) which exposes when the entry was first added to the git repository. Some kind of "Released on Homebrew Hub".

@avivace avivace self-assigned this Nov 18, 2023
@avivace avivace mentioned this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants