Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a free subset of the test suite #1160

Closed
pinobatch opened this issue Aug 17, 2023 · 1 comment · Fixed by #1161
Closed

Define a free subset of the test suite #1160

pinobatch opened this issue Aug 17, 2023 · 1 comment · Fixed by #1161

Comments

@pinobatch
Copy link
Member

Because #1159 made the semantics of local labels more lenient, it caused regression tests to fail. I learned that I could run test/run-tests.sh locally to see which tests' error output I needed to update. However, I hit another snag: running the complete test suite may infringe copyright in some jurisdictions.

$ test/run-tests.sh 
~/develop/assemblers/rgbds/test/asm ~/develop/assemblers/rgbds/test
align-16...
align-16.pipe...
[Numerous lines snipped]
Testing: ../../rgbgfx damaged9.png
Testing: ../../rgbgfx - <damaged9.png
~/develop/assemblers/rgbds/test
test/run-tests.sh: line 29: pushd: pokecrystal: No such file or directory
Please run `fetch-test-deps.sh` before running the test suite

Because SameBoy uses RGBDS to build its boot ROM, packaging SameBoy for Debian requires packaging RGBDS for Debian. In turn, packaging RGBDS for Debian requires following the Debian Free Software Guidelines. I doubt downloading a disassembly of Pokémon Crystal Version qualifies under DFSG. So I propose to create subsets of test/fetch-test-deps.sh and run-tests.sh called test/fetch-test-deps-dfsg.sh and run-tests-dfsg.sh. These would build only µCity, which is free software under GPLv3, not Pokémon.

@ISSOtm
Copy link
Member

ISSOtm commented Aug 17, 2023

This was also considered before, but not implemented due to a lack of motivation. This should be useful!

I'm not sure why you're considering SameBoy straight away but discarding any merit to packaging RGBDS itself. 😭 (/s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants