-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart linking #82
Comments
This would certainly reduce a lot of ROM bloat, such as in Pokemon Crystal EN-US. |
I'm not sure if this would be possible in all cases. Example:
But maybe for floating sections... |
Such sections could be specially marked as "preserve", couldn't they? |
Is there an IRC channel? |
#gbdev on EFNet, or the GBDev Discord server, why? |
Just wondering, it wasn't documented anywhere and I installed a new IRC
client recently.
|
toxa on gbdev Discord reports that dropping unused sections (those not reachable from |
I'm pretty sure it isn't a priority right now. |
This is not possible in general for non-floating sections, as AntonioND mentioned. People sometimes do write code that uses raw hex values for banks or addresses when they know what code/data to expect at those locations, so just looking at which labels are referenced wouldn't catch that. There's also a case in pokecrystal where two data tables (for mon pics and Unown pics) are both Perhaps floating sections could opt in to being left out if not referenced, like |
We could assign |
Enabling a feature like this by default is downright insane; I don't think anyone was even proposing this. It's pretty clear something like this should only be enabled by a flag. Isn't there already a flag for this purpose (that perhaps doesn't work very well)? |
@Rangi42 labels like those are trivial to reference with an |
@aaaaaa123456789 True, an It seems to me that since this would be a section-based feature, putting |
Maybe another section "kind", like we have |
Long-broken feature, fell into disrepair, got removed... Now it's back! Though, it needs testing. Fixes gbdev#82
Long-broken feature, fell into disrepair, got removed... Now it's back! Though, it needs testing. Fixes gbdev#82
Long-broken feature, fell into disrepair, got removed... Now it's back! Though, it needs testing. Fixes gbdev#82
Long-broken feature, fell into disrepair, got removed... Now it's back! Though, it needs testing. Fixes gbdev#82
Note that ASMotor has some kind of smart linking, though I don't know if it's complete/correct compared to what we'd need. |
The text was updated successfully, but these errors were encountered: