Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberParser uses trim() #7

Open
cgendreau opened this issue Dec 5, 2016 · 0 comments
Open

NumberParser uses trim() #7

cgendreau opened this issue Dec 5, 2016 · 0 comments

Comments

@cgendreau
Copy link
Contributor

Java String trim() only removes characters with code <= \u0020.

If NumberParser receives a whitespace like \u00A0 (Non-breaking space) the parsing won't work.

Guava's CharMatcher can handle it.

  1. We change usage of .tim() and use a CharMatcher
  2. We document the limitation of the method and we let the caller handle it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cgendreau