Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link_to : '#' is a bad default #20

Open
rizen opened this issue Nov 14, 2011 · 3 comments
Open

link_to : '#' is a bad default #20

rizen opened this issue Nov 14, 2011 · 3 comments

Comments

@rizen
Copy link

rizen commented Nov 14, 2011

I'd like to make a recommendation that the default link_to be 'javascript:void(0)' rather than '#'. There are two reasons for this:

  1. '#' actually causes the page to scroll

  2. If you're using jQuery pagination with a URL fragment writer like jQuery BBQ then it overwrites the fragment with just '#', which can be difficult to debug to understand why that is happening.

If you decide not to do this (which I understand), then I'd recommend adding a note in the docs for users to set it to 'javascript:void(0)' when doing URL fragment rewriting.

Anyway, thanks for an amazing pagingator! Oh, and per your request at the bottom of the docs, I'll be using jQuery pagination on sirishouldsay.com and probably eventually on thegamecrafter.com.

@iurisilvio
Copy link

+1 to this issue. I never complained about it, but I already had problem with this.

@IEfucker
Copy link

christ,I have a problem with hash set,for two days .finally. thanks guys.

@vctr-dev
Copy link

I've created a pull request for this #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants