Require atdgen-runtime >= 2.12.0 to avoid int64 representation bug #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serialized as JSON strings
mjambon
added a commit
to mjambon/opam-repository
that referenced
this pull request
Feb 27, 2024
gborough
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
@mjambon Thank you Martin for pointing this out! I thought I might have encountered this issue earlier while writing test cases but didn't follow up, now it makes sense.
I will cover this test case just in case and cut a new release.
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of atdgen-runtime incorrectly represent
int <ocaml repr="int64">as JSON strings instead of JSON numbers. I described the bug at ahrefs/atd#402 before realizing it was already fixed.I ran into this bug while having an old version of atdgen-runtime (2.11.0) on my machine despite running the latest atdgen (2.15.0).
Update: I submitted the same fix to opam-repository ocaml/opam-repository#25357