Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the recommended (and generated) Dockerfiles to be more inline with current best practices. The previous versions were in no way insecure, but it makes sense to make use of Docker secrets.
Summary of changes
dockerfile
CLI commandInstruction
classes in order to dynamically build them with less codeMost of the added lines correspond to the new test cases, where each one tests against a hardcoded Dockerfile.
I recommend we do not squash these commits.