Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Dockerfiles #16

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Better Dockerfiles #16

merged 3 commits into from
Oct 23, 2024

Conversation

gchqdev227
Copy link
Member

This PR updates the recommended (and generated) Dockerfiles to be more inline with current best practices. The previous versions were in no way insecure, but it makes sense to make use of Docker secrets.

Summary of changes

  • Dockerfiles are now generated with build secrets instead of multi-stage builds
  • Added new commands to the dockerfile CLI command
  • Better documentation on how the Dockerfiles are made up
  • Dockerfiles are generated from a number of Instruction classes in order to dynamically build them with less code

Most of the added lines correspond to the new test cases, where each one tests against a hardcoded Dockerfile.

I recommend we do not squash these commits.

@gchqdev227 gchqdev227 requested a review from ab295382 October 16, 2024 14:50
@gchqdev227 gchqdev227 self-assigned this Oct 16, 2024
@ab295382 ab295382 merged commit 108ea96 into main Oct 23, 2024
7 checks passed
@ab295382 ab295382 deleted the better-dockerfile branch October 23, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants