Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HqdmObjectFactory #211

Open
twalmsley opened this issue Apr 23, 2024 · 0 comments · May be fixed by #212
Open

Improve HqdmObjectFactory #211

twalmsley opened this issue Apr 23, 2024 · 0 comments · May be fixed by #212
Assignees

Comments

@twalmsley
Copy link
Collaborator

The class includes a large switch statement to decide which factory method to call to create an entity, perhaps it would be better to create a Map of names to methods instead and maybe the code would be easier to read and maintain. I will create a PR for review and it can be discussed there - I don't mind if the PR is rejected in the end, but at least it will have been considered.

@twalmsley twalmsley self-assigned this Apr 23, 2024
@twalmsley twalmsley linked a pull request Apr 23, 2024 that will close this issue
@twalmsley twalmsley linked a pull request Apr 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant