Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Control #66

Closed
twalmsley opened this issue Oct 31, 2022 · 1 comment · Fixed by #165
Closed

Transaction Control #66

twalmsley opened this issue Oct 31, 2022 · 1 comment · Fixed by #165
Assignees
Labels
enhancement New feature or request

Comments

@twalmsley
Copy link
Collaborator

twalmsley commented Oct 31, 2022

Change the DB transactions to default to WRITE for the *InTransaction() methods and provide overloaded versions with a transaction control parameter of type TxnType.

This is because the default for local TDB instances is READ_PROMOTE which might fail if, at the time of promotion, there have been some intervening updates.

Transactions on the RDFConnection for remote databases don't support READ_PROMOTE, so they are already WRITE transactions by default.

@twalmsley twalmsley added the enhancement New feature or request label Oct 31, 2022
@twalmsley twalmsley self-assigned this Oct 31, 2022
@twalmsley
Copy link
Collaborator Author

I'm going to change this so that the callers have to select the READ or WRITE version explicitly, and the same for runInTransaction - it will become runInWriteTransaction and runInReadTransaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant