Fixed broken links and typos in README.md #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the version number is also incorrect in the README. I had to use the dependancy with a version of |
|
Well spotted @Fabalab, thank you for pointing it out! |
|
I also think the groupId is incorrect. I found mine at |
|
We should also include descriptions and usage instructions for each of the sub-modules now that Magma Core is modularised. #69 |
That would definitely be useful. At the moment, I am compiling my own notes on each of the sub-modules... |
GCHQDeveloper42
requested review from
a team
and removed request for
GCHQDeveloper56
GCHQDeveloper56
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.