Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing dependency on Guava #308

Open
GCHQDeveloper314 opened this issue Apr 7, 2023 · 1 comment
Open

Investigate removing dependency on Guava #308

GCHQDeveloper314 opened this issue Apr 7, 2023 · 1 comment
Assignees
Labels
dependencies Updates/changes to Maven or other dependencies enhancement Improvement to existing functionality/feature
Milestone

Comments

@GCHQDeveloper314
Copy link
Member

Koryphe has a dependency on Guava, but the Guava methods used are simple and most functionality can be achieved with Java 8 built in methods.
Having a dependency on Guava makes Koryphe more difficult to use as a library due to version conflicts. While this can be mitigated with JAR shading, it would be better to not have the dependency at all.

Investigate removing the dependency on Guava entirely, or at least removing it from core code and using it as only a test dependency.

@GCHQDeveloper314 GCHQDeveloper314 added the enhancement Improvement to existing functionality/feature label Apr 7, 2023
@GCHQDeveloper314 GCHQDeveloper314 added this to the post-v2.0_backlog milestone Apr 7, 2023
@GCHQDeveloper314 GCHQDeveloper314 added the dependencies Updates/changes to Maven or other dependencies label Jul 12, 2023
@GCHQDeveloper314
Copy link
Member Author

It might be better to revisit this after moving entirely to Java 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates/changes to Maven or other dependencies enhancement Improvement to existing functionality/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant