Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-16 and gh-17 #18

Merged
merged 4 commits into from
May 11, 2017
Merged

gh-16 and gh-17 #18

merged 4 commits into from
May 11, 2017

Conversation

p013570
Copy link
Member

@p013570 p013570 commented May 11, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented May 11, 2017

Codecov Report

Merging #18 into develop will increase coverage by 1.68%.
The diff coverage is 66.5%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #18      +/-   ##
=============================================
+ Coverage      61.31%   62.99%   +1.68%     
- Complexity       386      429      +43     
=============================================
  Files             79       80       +1     
  Lines           1096     1262     +166     
  Branches          82      113      +31     
=============================================
+ Hits             672      795     +123     
- Misses           380      407      +27     
- Partials          44       60      +16
Impacted Files Coverage Δ Complexity Δ
...ple/binaryoperator/TupleAdaptedBinaryOperator.java 71.42% <ø> (ø) 5 <0> (ø) ⬇️
...yoperator/TupleAdaptedBinaryOperatorComposite.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...q/koryphe/tuple/function/TupleAdaptedFunction.java 80% <ø> (ø) 7 <0> (ø) ⬇️
...koryphe/tuple/predicate/TupleAdaptedPredicate.java 100% <ø> (+36.36%) 5 <0> (+1) ⬆️
...uple/predicate/TupleAdaptedPredicateComposite.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../tuple/function/TupleAdaptedFunctionComposite.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/uk/gov/gchq/koryphe/tuple/TupleInputAdapter.java 35.29% <0%> (ø) 3 <0> (ø) ⬇️
.../main/java/uk/gov/gchq/koryphe/tuple/MapTuple.java 52.94% <0%> (-11.35%) 5 <0> (ø)
...uk/gov/gchq/koryphe/tuple/ReferenceArrayTuple.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../uk/gov/gchq/koryphe/tuple/TupleOutputAdapter.java 28.57% <0%> (ø) 3 <0> (ø) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27f553...a0ddc91. Read the comment docs.


@Override
protected Float aggregateFloat(final Float a, final Float b) {
return a * b;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, is it worth warning about precision errors here? Would we want to support aggregation of BigDecimal and BigInteger?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created an issue to think about number overflows: gh-19.

@p013570 p013570 merged commit f566eed into develop May 11, 2017
@p013570 p013570 deleted the gh-16-input-validation branch May 11, 2017 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants