-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-16 and gh-17 #18
gh-16 and gh-17 #18
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #18 +/- ##
=============================================
+ Coverage 61.31% 62.99% +1.68%
- Complexity 386 429 +43
=============================================
Files 79 80 +1
Lines 1096 1262 +166
Branches 82 113 +31
=============================================
+ Hits 672 795 +123
- Misses 380 407 +27
- Partials 44 60 +16
Continue to review full report at Codecov.
|
|
||
@Override | ||
protected Float aggregateFloat(final Float a, final Float b) { | ||
return a * b; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an aside, is it worth warning about precision errors here? Would we want to support aggregation of BigDecimal and BigInteger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created an issue to think about number overflows: gh-19.
No description provided.