From 2ce79aa203dfef759c82bc41b160a80de9bf2d6a Mon Sep 17 00:00:00 2001
From: Georgi Christov <7644787+gchristov@users.noreply.github.com>
Date: Tue, 19 Nov 2024 10:02:22 +0100
Subject: [PATCH] Remove the yarn mutex

---
 .github/actions/build-service/action.yml | 2 +-
 .github/actions/unit-test/action.yml     | 2 ++
 .github/workflows/nightly-check.yml      | 2 +-
 .yarnrc                                  | 1 -
 4 files changed, 4 insertions(+), 3 deletions(-)
 delete mode 100644 .yarnrc

diff --git a/.github/actions/build-service/action.yml b/.github/actions/build-service/action.yml
index c28bf7e5..c06b48e1 100644
--- a/.github/actions/build-service/action.yml
+++ b/.github/actions/build-service/action.yml
@@ -11,7 +11,7 @@ runs:
         set -Eeuo pipefail
         
         if [ -e "${{ inputs.service }}/gradlew" ]; then
-          # Need to explicitly cd into each service, otherwise we get yarn cache clashes
+          # Need to explicitly cd into each service, otherwise we get concurrent yarn cache clashes
           cd ${{ inputs.service }}
           ./gradlew --no-daemon assemble
           cd ..
diff --git a/.github/actions/unit-test/action.yml b/.github/actions/unit-test/action.yml
index bbb0cf97..829a66ab 100644
--- a/.github/actions/unit-test/action.yml
+++ b/.github/actions/unit-test/action.yml
@@ -8,6 +8,8 @@ runs:
       shell: bash
       run: |
         set -Eeuo pipefail 
+        # A single worker is a workaround for the concurrent yarn instances that multi-workers brings,
+        # where the cache directory is being updated in parallel, causing conflicting changes.
         ./gradlew --no-daemon --continue --max-workers=1 jsTest
     - name: Generate test report
       uses: mikepenz/action-junit-report@v4
diff --git a/.github/workflows/nightly-check.yml b/.github/workflows/nightly-check.yml
index 068a779a..b3c088d8 100644
--- a/.github/workflows/nightly-check.yml
+++ b/.github/workflows/nightly-check.yml
@@ -28,7 +28,7 @@ jobs:
       - name: Build services
         run: |
           set -Eeuo pipefail
-          ./gradlew --no-daemon  assemble
+          ./gradlew --no-daemon assemble
       - name: Preview infrastructure
         uses: ./.github/actions/infra
         with:
diff --git a/.yarnrc b/.yarnrc
deleted file mode 100644
index 9bd0c338..00000000
--- a/.yarnrc
+++ /dev/null
@@ -1 +0,0 @@
---install.mutex network
\ No newline at end of file