Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of push/commit/init syscalls #4284

Open
playX18 opened this issue Oct 10, 2024 · 0 comments
Open

Get rid of push/commit/init syscalls #4284

playX18 opened this issue Oct 10, 2024 · 0 comments
Assignees
Labels
C2-refactoring Refactoring proposal

Comments

@playX18
Copy link
Member

playX18 commented Oct 10, 2024

Proposal

On last call everyone agreed it is a good idea to get rid of syscalls like send_commit, send_push and others. Rationale for this is that these syscalls:

  • Hardly used by anyone
  • Hard to maintain: these syscalls need to preserve state of partially constructed messages between some actions e.g gr_wait and we need to maintain this invariant in the entirety of code.

What should users do?

If there's any users of these syscalls they should implement similar mechanism of constructing partial messages on their own using static storage e.g static mut in Rust.

@playX18 playX18 added the C2-refactoring Refactoring proposal label Oct 10, 2024
@playX18 playX18 self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C2-refactoring Refactoring proposal
Projects
None yet
Development

No branches or pull requests

1 participant